Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File storage backend's atomic rename implementation is not async #369

Closed
houqp opened this issue Aug 9, 2021 · 0 comments · Fixed by #471
Closed

File storage backend's atomic rename implementation is not async #369

houqp opened this issue Aug 9, 2021 · 0 comments · Fixed by #471
Labels
binding/rust Issues for the Rust crate bug Something isn't working help wanted Extra attention is needed

Comments

@houqp
Copy link
Member

houqp commented Aug 9, 2021

Environment

Delta-rs version: all

Binding: rust

Bug

What happened:

atomic_rename in file storage backend could block the tokio runtime entirely because it is not async

What you expected to happen:

perform syscall asynchronously in atomic rename.

How to reproduce it:

run atomic rename and see no other tokio tasks being able to execute until it returns.

More details:

Look into tokio::fs source code for inspiration on how to make syscalls async.
@houqp houqp added bug Something isn't working help wanted Extra attention is needed binding/rust Issues for the Rust crate labels Aug 9, 2021
@houqp houqp mentioned this issue Aug 9, 2021
Merged
@viirya viirya mentioned this issue Oct 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
binding/rust Issues for the Rust crate bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make file storage backend's atomic rename async viirya/delta-rs
1 participant
@houqp