Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move version field into DeltaTableState struct #390

Closed
houqp opened this issue Aug 16, 2021 · 2 comments · Fixed by #649
Closed

Move version field into DeltaTableState struct #390

houqp opened this issue Aug 16, 2021 · 2 comments · Fixed by #649
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@houqp
Copy link
Member

houqp commented Aug 16, 2021

Description

version is currently a field in DeltaTable. It would make more sense to move this into DeltaTableState since version maps one to one to state.

@houqp houqp added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 16, 2021
@explicite
Copy link

@houqp I raised draft for this #553

Still no sure:

  1. if we should expose whole state on table
  2. Ruby/Python we should move object like state to DeltaTable... definitions, or expose only version

Thanks for advice

@houqp
Copy link
Member Author

houqp commented Jan 30, 2022

Thanks @explicite for taking on this task! The general rule of thumb for exposing internal fields as public is to consider whether there is a dependency between the field we want to expose with any other field in the struct. In this case, I think version was the only field that correlates to state, so it should be safe to expose the state field after we moved the version field into it. If a field is exposed in the Rust side, I think it's reasonable to expose it to python/ruby as well if you want to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants