Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The experimental writer need pandas dependency #596

Closed
fvaleye opened this issue May 4, 2022 · 0 comments · Fixed by #597
Closed

The experimental writer need pandas dependency #596

fvaleye opened this issue May 4, 2022 · 0 comments · Fixed by #597
Labels
binding/python Issues for the Python package bug Something isn't working

Comments

@fvaleye
Copy link
Collaborator

fvaleye commented May 4, 2022

Environment

Delta-rs version: python-v0.5.7

Binding: Python


Bug

What happened:
When installing the deltalake python package without pandas as optional dependency.

The import fails in the writer.py file since it required the pandas dependency:

site-packages/deltalake/writer.py:8: in <module>
    import pandas as pd
E   ModuleNotFoundError: No module named 'pandas'

What you expected to happen:
Have everything ready to work without requiring to install pandas if we are not using the writer capability.

Possible solutions:

  • Create a dedicated write_deltalake_from_pandas method to avoid checking the instance of the data as dataframe
  • Add only pandas for types checking like this
  • Check if pandas is installed with a bool when importing and add this check before this check
@fvaleye fvaleye added bug Something isn't working binding/python Issues for the Python package labels May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant