Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Server's SSL Certificate #108

Open
VivekUchiha opened this issue Jan 14, 2020 · 3 comments
Open

Removing Server's SSL Certificate #108

VivekUchiha opened this issue Jan 14, 2020 · 3 comments
Labels
next year
Milestone
Testing Phase

Comments

@VivekUchiha
Copy link
Collaborator

The server's Certificate is hardcoded in the app which is not a good practice. Find a solution for this. One may be to get a trusted certificate for the server which does not need special whitelisting on the app.
@avikumar15
Copy link
Member

Modified TrustManager to accept all the generated certificates which removes the use of having CERT KEY in the code, and runs server.

@VivekUchiha
Copy link
Collaborator Author

This seems to solve the issue but beats the whole point of SSL certificates. @Harsh2098 thoughts?

@Harsh2098
Copy link
Collaborator

Do you get OK response from the server though for any RPC method? Can you push the code to new branch, I'll check that

@Harsh2098 Harsh2098 added this to the Testing Phase milestone Jan 16, 2020
@delta delta locked as too heated and limited conversation to collaborators Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
next year
Projects
None yet
Milestone
Testing Phase
Development

No branches or pull requests
4 participants
@Harsh2098 @VivekUchiha @avikumar15 @ranaaditya