feat: Set summary thumbnail path for WebXDCs to "webxdc-icon://last-msg-id" (#5782) #5789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
commented
Jul 21, 2024
src/summary.rs
Outdated
| @@ -129,6 +129,8 @@ impl Summary { | |||
| { | |||
| msg.get_file(context) | |||
| .and_then(|path| path.to_str().map(|p| p.to_owned())) | |||
| } else if msg.viewtype == Viewtype::Webxdc { | |||
| Some("msg-icon://last-msg-id".to_string()) | |||
There was a problem hiding this comment.
The suggestion was "webxdc-icon:last-msg-id", but i think:
- This should be path-like, so let's use "msg-icon://" as a prefix
- Better not to add "webxdc", this way the string can be reused for other viewtypes if we want. It's just a hint, how the icon should be taken exactly is up to the app
There was a problem hiding this comment.
actually it should contain webxdc IMO, because the ui in desktop just replaces it with the url for the custom uri scheme that serves webxdc icons. I don't see much point in having an api that requires an extra if statement in ui code.
There was a problem hiding this comment.
I changed it to "webxdc-icon://last-msg-id"
…sg-id" (#5782) This is a hint for apps that a WebXDC icon should be shown in the summary, e.g. in the chatlist. Otherwise it's not clear when it should be shown, e.g. it shouldn't be shown in a reaction summary.
iequidoo
force-pushed
the
iequidoo/webxdc-summary-icon
branch
from
f41df0c
to
f90171c
Compare
iequidoo
changed the title
Simon-Laux
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hint for apps that a WebXDC icon should be shown in the summary, e.g. in the chatlist. Otherwise it's not clear when it should be shown, e.g. it shouldn't be shown in a reaction summary.
#5782 should be closed after the corresponding DC Desktop fix.