View Profile: "Edit Name" is not available when accessing the contact from the members section in a group view

[Simon-Laux]

Edit Name is not available when accessing the contact from the members section in a group view.
It is confusing to have 2 slightly different versions of the same view, depending on how it was opened.

[farooqkz]

Can you elaborate on this please? Like steps to reproduce?

[Simon-Laux]

When accessing the profile view directly:

When clicking on a member in a group view:

Note that the pen icon/button to edit the contacts name is missing in that case. I think that is confusing and it should always be accessible.

[farooqkz]

From what I understand reading the code, there are actually two different dialogs shown to the user:

• If the user is in ViewGroup and clicks on someone, simply the viewMode state of this component is changed to profile and a profile using the same component is shown.
• If the user goes some other way to view the profile, like right-click on DM with someone and then "View Profile", the "ViewProfille" component is shown.

[Simon-Laux]

Right that part seems to be outside of ViewProfileInner, still we can copy the following over to the other dialog:

• the onClickEdit function
• the showEditButton condition (maybe though that condition is unreachable, you can not have a group with the "device chat contact" and you can not click on yourself in the group list, so you might as well always show the edit button)
• if profileContact and only if it is set then we need to update it when the contact changes (for example when you edit the name, this requires a more involved use effect, so I can do that part if required. (is not really a good first issue anymore unless one is a react expert)

[farooqkz]

Why not take the harder but the right way and show the same dialog everywhere?

[Simon-Laux]

Why not take the harder but the right way and show the same dialog everywhere?

We need to think over the whole dialog systems at some point anyway and refactor everything, so I think the duplication is fine for now, I also don't like it, but if we put in the effort we should remove blueprints in that part too while we will be already at it. So better postpone bigger refactoring IMO.