Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: New email adresses should be stripped #3357

Closed
Septias opened this issue Aug 16, 2023 · 2 comments · Fixed by #3364
Closed

fix: New email adresses should be stripped #3357

Septias opened this issue Aug 16, 2023 · 2 comments · Fixed by #3364
Assignees
@Simon-Laux
Labels
bug Something isn't working

Comments

@Septias
Copy link
Contributor

Septias commented Aug 16, 2023

When adding an email address that has a leading whitespace, nothing happens when clicking on "New Contact". From the console, it can be taken that an invalid email address was given to the core. If this is the case, then an error message should probably be shown. For this issue to close it is enough to just strip the entered email address though.
@farooqkz
Copy link
Collaborator

Hello @Septias . Which version did you try? AFAIK, it was fixed in the latest version.

@Simon-Laux
Copy link
Member

still an issue, can reproduce it in 1.40 and in master

@Simon-Laux Simon-Laux added the bug Something isn't working label Aug 28, 2023
@Simon-Laux Simon-Laux self-assigned this Aug 28, 2023
@Simon-Laux Simon-Laux mentioned this issue Aug 28, 2023
Merged
Simon-Laux added a commit that referenced this issue Aug 28, 2023
@Simon-Laux
fix contact createion in new chat dialog not working with leading or …
ef4e4a0 
…trailing spaces.

closes #3357
Simon-Laux added a commit that referenced this issue Aug 28, 2023
@Simon-Laux
fix contact creation in new chat dialog not working with leading or t…
ffdae32 
…railing spaces. (#3364)

* fix contact createion in new chat dialog not working with leading or trailing spaces.

closes #3357

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Simon-Laux Simon-Laux

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@farooqkz @Simon-Laux @Septias