Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve confirmation message when trying to delete a 1:1 chat #4050

Closed
iequidoo opened this issue Jul 25, 2024 · 2 comments
Closed

Improve confirmation message when trying to delete a 1:1 chat #4050

iequidoo opened this issue Jul 25, 2024 · 2 comments
Assignees
@maxphilippov

Comments

@iequidoo
Copy link

Now it says Are you sure you want to delete "email@address"? One could think that the contact will be deleted, not the chat. Secondly, chatmail addresses don't tell much. Btw, for group chats the message looks good, it uses the chat name. As for DC Android, it asks Delete 1 chat? It will no longer be shown in the chat list; its messages will remain on the server. I.e. no contact name as well, but it's clear what will happen at least.
maxphilippov added a commit that referenced this issue Aug 5, 2024
@maxphilippov
Fix empty space and zoom in HTML mail view
d9de994 
- zoom in email content dependes both on window zoom and settings
  zoomFactor
- email contents window in HTML mail view positioning is fixed
- resolves #4050
maxphilippov added a commit that referenced this issue Aug 5, 2024
@maxphilippov
Fix empty space and zoom in HTML mail view
a6694b2 
- zoom in email content dependes both on window zoom and settings
  zoomFactor
- email contents window in HTML mail view positioning is fixed
- resolves #4050
maxphilippov added a commit that referenced this issue Aug 5, 2024
@maxphilippov
Fix empty space and zoom in HTML mail view
06cacb0 
- zoom in email content dependes both on window zoom and settings
  zoomFactor
- email contents window in HTML mail view positioning is fixed
- resolves #4050
@iequidoo
Copy link
Author

iequidoo commented Aug 5, 2024

I think ef3aa04 fixes #4052, but not this issue. If i'm wrong please close again :)

@iequidoo iequidoo reopened this Aug 5, 2024
@maxphilippov maxphilippov self-assigned this Aug 6, 2024
maxphilippov added a commit that referenced this issue Aug 8, 2024
@maxphilippov
Rephrase english chat remove translation
e6dc63e 
- resolves #4050
@maxphilippov maxphilippov mentioned this issue Aug 8, 2024
Closed
maxphilippov added a commit that referenced this issue Aug 8, 2024
@maxphilippov
Rephrase english chat remove translation
35b5a0f 
- resolves #4050
@r10s
Copy link
Member

r10s commented Aug 9, 2024

closing, this seemed to be a misunderstanding; the string is anyways improved at deltachat/deltachat-android#3219 as discussed at #4072

@r10s r10s closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxphilippov maxphilippov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rephrase english 'delete chat' translation deltachat/deltachat-desktop
3 participants
@maxphilippov @r10s @iequidoo