Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML email viewer: content context menu has no items without selection #4053

Closed
Simon-Laux opened this issue Jul 28, 2024 · 0 comments · Fixed by #4060
Closed

HTML email viewer: content context menu has no items without selection #4053

Simon-Laux opened this issue Jul 28, 2024 · 0 comments · Fixed by #4060
Assignees
@maxphilippov
Labels
bug Something isn't working good first issue Good for newcomers OS: Linux

Comments

@Simon-Laux
Copy link
Member

Simon-Laux commented Jul 28, 2024 •
edited
Loading

Observed on linux flatpak gnome with dc version 1.46.1:
image
On macOS with dc version 1.46.1 it looks like this:
Bildschirmfoto 2024-07-28 um 21 22 49
But also selects the word under the mouse.
With a selection it also works under linux, but it still shows the extra separator item, which shouldn't be there if nothing comes after it.

I think the problem is the separator item(s) which make the context menu appear even then there is no selection.
@Simon-Laux Simon-Laux added bug Something isn't working good first issue Good for newcomers OS: Linux labels Jul 28, 2024
@maxphilippov maxphilippov self-assigned this Aug 2, 2024
maxphilippov added a commit that referenced this issue Aug 2, 2024
@maxphilippov
Fix empty context menu in HTML viewer
30ed8c8 
- don't disply HTML mail viewer context menu if it's empty
- hide unnecessary separators
- resolves #4053
@maxphilippov maxphilippov mentioned this issue Aug 2, 2024
Merged
maxphilippov added a commit that referenced this issue Aug 3, 2024
@maxphilippov
Fix empty context menu in HTML viewer (#4060)
7425a62 
- don't disply HTML mail viewer context menu if it's empty
- hide unnecessary separators
- resolves #4053
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxphilippov maxphilippov

Labels
bug Something isn't working good first issue Good for newcomers OS: Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix empty context menu in HTML viewer deltachat/deltachat-desktop
2 participants
@maxphilippov @Simon-Laux