Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash, when trying to tap "Settings" of another profile #4190

Closed
r10s opened this issue Oct 8, 2024 · 0 comments · Fixed by #4192
Closed

crash, when trying to tap "Settings" of another profile #4190

r10s opened this issue Oct 8, 2024 · 0 comments · Fixed by #4192
Assignees
@maxphilippov
Labels
bug Something isn't working

Comments

@r10s
Copy link
Member

r10s commented Oct 8, 2024 •
edited
Loading

when right-tapping the profile image of a not selected profile, and then select "Settings", the app crashes.

Screen.Recording.2024-10-08.at.12.36.16.mov

tested on 1.46.8 and on current master on macOS 14.5, log
@r10s r10s added the bug Something isn't working label Oct 8, 2024
@maxphilippov maxphilippov self-assigned this Oct 8, 2024
maxphilippov added a commit that referenced this issue Oct 8, 2024
@maxphilippov
Fix Settings/AllMedia in Account List context menu
0a62166 
- combine all settings-gathering when changing account since some
  functions await for SelectAccount
- give additional 50ms to switching to Gallery since there's a conflict
  of setState and async media query in Gallery.tsx
- resolves #4190
- resolves #4191
@maxphilippov maxphilippov mentioned this issue Oct 8, 2024
Merged
maxphilippov added a commit that referenced this issue Oct 8, 2024
@maxphilippov
Fix Settings/AllMedia in Account List context menu
a30ee7e 
- combine all settings-gathering when changing account since some
  functions await for SelectAccount
- give additional 50ms to switching to Gallery since there's a conflict
  of setState and async media query in Gallery.tsx
- resolves #4190
- resolves #4191
maxphilippov added a commit that referenced this issue Oct 8, 2024
@maxphilippov
Fix Settings/AllMedia in Account List context menu
26ef614 
- combine all settings-gathering when changing account since some
  functions await for SelectAccount
- give additional 50ms to switching to Gallery since there's a conflict
  of setState and async media query in Gallery.tsx
- resolves #4190
- resolves #4191
maxphilippov added a commit that referenced this issue Oct 8, 2024
@maxphilippov
Fix Settings/AllMedia in Account List context menu
532913c 
- combine all settings-gathering when changing account since some
  functions await for SelectAccount
- give additional 50ms to switching to Gallery since there's a conflict
  of setState and async media query in Gallery.tsx
- resolves #4190
- resolves #4191
maxphilippov added a commit that referenced this issue Oct 10, 2024
@maxphilippov
Fix Settings/AllMedia in Account List context menu
2d55c5b 
- combine all settings-gathering when changing account since some
  functions await for SelectAccount
- give additional 50ms to switching to Gallery since there's a conflict
  of setState and async media query in Gallery.tsx
- resolves #4190
- resolves #4191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxphilippov maxphilippov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Settings/AllMedia in Account List context menu deltachat/deltachat-desktop
2 participants
@maxphilippov @r10s