Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix contact creation in new chat dialog not working with leading or trailing spaces. #3364

Merged
merged 2 commits into from
Aug 28, 2023
Merged

fix contact creation in new chat dialog not working with leading or trailing spaces. #3364

merged 2 commits into from
Aug 28, 2023

Conversation

Simon-Laux
Copy link
Member

closes #3357

@Simon-Laux Simon-Laux added the bug Something isn't working label Aug 28, 2023
@Simon-Laux Simon-Laux changed the title fix contact createion in new chat dialog not working with leading or trailing spaces. fix contact creation in new chat dialog not working with leading or trailing spaces. Aug 28, 2023
Simon-Laux
Simon-Laux commented Aug 28, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Septias
Septias approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@Septias Septias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really give a good analysis of the code changes, but trimming stuff shouldn't produce much errors anyway. Thanks for the fix :)

@Simon-Laux Simon-Laux merged commit ffdae32 into master Aug 28, 2023
6 checks passed
@Simon-Laux Simon-Laux deleted the simon/fix-3357 branch August 28, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Septias Septias Septias approved these changes

@farooqkz farooqkz Awaiting requested review from farooqkz

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: New email adresses should be stripped
2 participants
@Simon-Laux @Septias