Improve layout and fix unknown locale of DisabledMessageInput
#3537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adzialocha
commented
Nov 16, 2023
adzialocha
commented
Nov 16, 2023
|
I think I would keep the unknown, but throw the error instead when the Why? to not crash the whole app when core adds a new feature to disable sending in a new case. but to have the error when desktop devs forget to fully implement a |
Simon-Laux
reviewed
Nov 16, 2023
|
How is this now @Simon-Laux? Now as you said the unknown case is not crashing but returning a "weird" string to signal something is off. I didn't use the |
Simon-Laux
reviewed
Nov 17, 2023
Simon-Laux
approved these changes
Nov 17, 2023
Co-authored-by: Simon Laux <Simon-Laux@users.noreply.github.com>
adzialocha
added a commit
that referenced
this pull request
Nov 21, 2023
* master: (29 commits) fix double message context menu (#3551) fix displaying sticker that has wrong mimetype (#3552) fix bug where composer was locked after joining a group via qr code (#3547) prepare 1.41.3 comment out verbose logging of store add `vi` to appx supported languages let's hope that this does not break the ms store again, it was on the ms list of supported languages, so I hope that it does not break it. Update translations (17.11.2023) and add Vietnamese language fix translation key for `add_to_sticker_collection` in context menu (#3544) fix eslint Select device message chat automatically to welcome first users (#3531) Improve layout and fix unknown locale of `DisabledMessageInput` (#3537) Use `dc_chat_can_send` to show or hide reply functionality (#3541) add more debug logging when clearing notifications (#3534) update deltachat-node and deltachat/jsonrpc-client to `v1.131.4` (#3539) update local help (#3538) Fix: Do not show reply option in read-only groups (#3536) Update options for disappearing messages (#3530) Do not show redundant read-only message when in device messages chat (#3532) fix: bug in emoji detection for jumbomoji #3508 update deltachat-node and deltachat/jsonrpc-client to `v1.131.3` ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR from #3532
Minor fixes:
useRefas it doesn't really have a use in this scenarioLayout fix:
CSS: Center text always, also in narrow window sizes, independent of padding
Before:
After: