Refactor chat store logic into dedicated React contexts #3725

adzialocha · 2024-03-07T10:16:58Z

Remove ChatStore
Move "global" chat state to ChatContext

Closes: #3675

src/renderer/ScreenController.tsx

src/renderer/contexts/ChatContext.tsx

src/renderer/components/Runtime.tsx

src/renderer/hooks/usePrivateReply.ts

src/renderer/backend/chat.ts

adzialocha · 2024-04-03T12:01:33Z

I think the refactoring is so far complete, I'll look into bugs now which probably occurred after touching so much

src/renderer/ScreenController.tsx

src/renderer/components/QrErrorMessage.tsx

src/renderer/components/RuntimeAdapter.tsx

src/renderer/components/chat/ChatListContextMenu.tsx

src/renderer/runtime.ts

src/renderer/hooks/useProcessQr.ts

adzialocha · 2024-04-12T10:32:06Z

I'm not sure why this is stuck on throwing linting errors about things which do not exist anymore, restarting the CI didn't help ..

In any case, this PR is ready for review and merging.

src/renderer/backend/chat.ts

Simon-Laux

When switching accounts the account sidebar flickers, we should somehow prevent it from completely reloading (visually popping in unread counters) in that case.

Generally the code looks really nice now! Thanks very much for taking on this refactoring, it's a huge leap forward and was easy to review 🚀 🌟

src/renderer/components/MessageListView.tsx

src/renderer/hooks/useSendCallInvitation.ts

src/renderer/contexts/ChatContext.tsx

Simon-Laux · 2024-04-12T15:50:58Z

src/renderer/contexts/ChatContext.tsx

+        return
+      }
+
+      if (!chat) {


we can also check for chat type, if it's not a 1on1/DM chat then a contact update does not affect it AFAIK

I'm actually not 100% sure why this update is required at all, could you explain what this is for, then I'll add it as a comment. Thank you!

I guess if contact name, avatar or recently seen changes on a 1on1 chat. maybe only the recently seen in reality I don't know in my head if the other events trigger a chat update instead or also rely on the ContactsChanged event

I'm still confused why this update is required and why it is only for 1:1 chats. Maybe I'll leave it as-is for now (as this is how it was before as well) and we can add commentary / adjustments later?

src/renderer/hooks/usePrevious.ts

nicodh

Looks like a good refactoring and cleanup to me!
Only some ideas for naming and comments. In general I prefer more verbose comments, they are removed anyway when compiled.

src/renderer/contexts/ChatContext.tsx

src/renderer/hooks/useSelectLastChat.ts

src/renderer/hooks/useChat.ts

…er components

Co-authored-by: Simon Laux <Simon-Laux@users.noreply.github.com>

adzialocha added the refactor This PR or issue is about refactoring label Mar 7, 2024

adzialocha mentioned this pull request Mar 7, 2024

Revert buggy workaround for race conditions in chat store #3726

Closed

Simon-Laux reviewed Mar 7, 2024

View reviewed changes

src/renderer/ScreenController.tsx Outdated Show resolved Hide resolved

Simon-Laux mentioned this pull request Mar 9, 2024

move select selected chat up to select account #3724

Merged

Simon-Laux reviewed Mar 19, 2024

View reviewed changes

src/renderer/contexts/ChatContext.tsx Outdated Show resolved Hide resolved

Simon-Laux assigned adzialocha Mar 27, 2024

Simon-Laux reviewed Apr 2, 2024

View reviewed changes

src/renderer/components/Runtime.tsx Outdated Show resolved Hide resolved

Simon-Laux reviewed Apr 2, 2024

View reviewed changes

src/renderer/hooks/usePrivateReply.ts Outdated Show resolved Hide resolved

Simon-Laux reviewed Apr 2, 2024

View reviewed changes

src/renderer/backend/chat.ts Outdated Show resolved Hide resolved

adzialocha force-pushed the adz/chat-store-refactor branch from f7ffb20 to d4fdb3c Compare April 3, 2024 11:21