perf: hide/show on-hover shortcut menu with CSS #3751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
perf-shortcut-menu-css
branch
2 times, most recently
from
3046199
to
59488f7
Compare
WofWca
force-pushed
the
perf-shortcut-menu-css
branch
from
59488f7
to
a218f12
Compare
adzialocha
approved these changes
Apr 9, 2024
Comment on lines
+67
to
70
| <li id={props.key2} className='message-wrapper'> | ||
| <Message {...props} /> | ||
| <div className='message-observer-bottom' id={'bottom-' + props.key2} /> | ||
| </li> |
There was a problem hiding this comment.
We could use the new SCSS module approach here for anything new (styles in scss folder are deprecated)
There was a problem hiding this comment.
we can move it later along with the other remaining message styles.
|
please rebase onto |
Simon-Laux
approved these changes
Apr 9, 2024
...instead of JS. Previously hovering over a different message would
cause the whole message list to re-render.
There are slight behavioral changes:
- Previously if you pointed the cursor to a message, then scrolled the
chat without moving the pointer, it would keep the menu on top
of the initial message, despite the cursor pointing at a different
message after the scroll.
- Now when the three-dot menu is clicked, the shortcuts menu disappears
- When you point on emojis, the menu also disappears
The new behavior more closely resembles that of Signal.
WofWca
force-pushed
the
perf-shortcut-menu-css
branch
from
a218f12
to
7bc81f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why WIP:
...instead of JS. Previously hovering over a different message would
cause the whole message list to re-render.
There are slight behavioral changes:
chat without moving the pointer, it would keep the menu on top
of the initial message, despite the cursor pointing at a different
message after the scroll.
The new behavior more closely resembles that of Signal.