remove deprecated string #3756
Merged
remove deprecated string #3756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to not clutter UI, we do not show a "reasoning bar" at all for the device chat.
r10s
force-pushed
the
r10s/remove-deprecated-string
branch
from
30b5a6e
to
f0852b0
Compare
i think, checking for `!reason` after `switch()` is a bug; it seems one wanted to check for the outcome of the `switch()`, so `!reasonMessage`
r10s
force-pushed
the
r10s/remove-deprecated-string
branch
2 times, most recently
from
9149318
to
04e2a62
Compare
r10s
force-pushed
the
r10s/remove-deprecated-string
branch
from
04e2a62
to
9146b60
Compare
Simon-Laux
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR avoids getting translation for the string
messaging_disabled_device_chatthat is discarded a few lines later anyways.(to not clutter UI, we do not show a "reasoning bar" at all for the device chat and the string is about to being removed to not add unnecessary work to the translators)
moreover, the second commit aims to cleanup the flow