Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix right click in ContactList should open a context menu #3884

Conversation

Simon-Laux
Copy link
Member

@Simon-Laux Simon-Laux commented May 30, 2024

  • fix: right click in ContactList should open a context menu
  • don't show deletion option for selfcontact

@Simon-Laux Simon-Laux added the bug Something isn't working label May 30, 2024
@Simon-Laux Simon-Laux requested review from nicodh and r10s May 30, 2024 16:44
Copy link
Contributor

@nicodh nicodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just stumbled over the fact that many clickable items miss the cursor:pointer class: The contact context menu (Delete contact), the contact items and the chat list while the accounts have a pointer cursor...

Is that intentionally?

@r10s
Copy link
Member

r10s commented May 30, 2024

in general, we try to follow the unagitated desktop-approach for the mouse curser.

for desktop-apps, there is no rule "everything that is tappable" gets the pointing hand. in dc-desktop, we got some mix:

so, changing the cursor to a pointing hand makes more sense when the items are smaller, not directly beside each other and and not "well known" - so, eg "start" button for webxdc, links, icons in the main window.

changing the cursor makes less sense, when items are beside each other without gaps, or at well known positions. eg. for the chatlist, half of the screen would be a pointing hand otherwise. also for window-tools as close/fullscreen - and for menus, the pointing hand makes less sense and is usually also not used by the os

some "hard rules" may be easier, however, eg. for the chatlist it also looks worse, and for the menus unexpected, both from the view to a desktop app, so it stays a bit vague.

@nicodh
Copy link
Contributor

nicodh commented May 30, 2024

Ok, at least in Slack or VSCode every clickable item changes the cursor to a pointer.
Anyway fine for me, I just wanted to know if it is intentionally

@Simon-Laux Simon-Laux merged commit 9aef65f into main Jun 3, 2024
7 checks passed
@Simon-Laux Simon-Laux deleted the simon/i3880-context-menu-for-delete-contact-in-new-chat-dialog branch June 3, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

right click in ContactList immediately opens confirmDialog to delete contact
3 participants