performance: memorize MessageBody, don't run message parser multiple times for the same message #3951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Simon-Laux
commented
Jun 17, 2024
•
Simon-Laux
commented
- performance: memorize MessageBody, don't run message parser multiple times for the same message
- performance: add limits for MessageBody text generally and for quotes, core already has limits on text size, but for the cases where core has a bug it's still useful to have a failsave
WofWca
approved these changes
Jun 17, 2024
…times for the same message Add pr number to changelog
…, core already has limits on text size, but for the cases where core has a bug it's still useful to have a failsave
Simon-Laux
force-pushed
the
simon/perf-memorize-message-body
branch
from
7682962
to
25153c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.