Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore notification close event & clear notifications when marking accounts unread chat as noticed #4010

Merged
merged 6 commits into from
Jul 8, 2024

Conversation

nicodh
Copy link
Contributor

@nicodh nicodh commented Jul 5, 2024

fixes #4002

@nicodh
Copy link
Contributor Author

nicodh commented Jul 5, 2024

I will test on Windows to resolve #3982

@nicodh
Copy link
Contributor Author

nicodh commented Jul 5, 2024

I also found an entry in the ChatListItemArchiveLink context menu "Mark al as read" which makes no sense imho since new messages in archived chats are not displayed as new at all.
@Simon-Laux is there a case where this makes sense? Otherwise I will remove it
ArchiveLink-Context-Menu

@Simon-Laux
Copy link
Member

mute a chat then archive it. then receive a message for it. archived chats show a badge counter that tells the number of archived muted chats with unread messages.
muted chats stay archived when a new message is received.
So this context menu is intentional and useful.

@Simon-Laux Simon-Laux added the bug Something isn't working label Jul 5, 2024
@Simon-Laux Simon-Laux changed the title WIP: Ignore notification close event WIP: Ignore notification close event & clear notifications when marking accounts unread chat as noticed Jul 5, 2024
@nicodh nicodh changed the title WIP: Ignore notification close event & clear notifications when marking accounts unread chat as noticed Ignore notification close event & clear notifications when marking accounts unread chat as noticed Jul 7, 2024
@nicodh
Copy link
Contributor Author

nicodh commented Jul 7, 2024

Tested on Windows, Mac & Linux

Works as expected, except a bug in Linux which is not related to deltachat (notifications are never removed from notification)
#3982 ist not solved with this MR but not really related

@nicodh nicodh requested a review from Simon-Laux July 7, 2024 05:53
@@ -26,6 +26,7 @@
- Fix the problem of Quit menu item on WebXDC apps closes the whole DC app #3995
- minor performance improvements #3981
- fix chat list items (e.g. Archive) and contacts not showing up sometimes #4004
- fix bug notifications not being removed on Mac #4010
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgot to mention the fix for clear account notifications

@nicodh nicodh merged commit de093a0 into main Jul 8, 2024
7 checks passed
@nicodh nicodh deleted the clear-notifications branch July 8, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Mark All as Read" does not remove notifications
2 participants