Select chat after forwarding #4029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-Laux
reviewed
Jul 13, 2024
| @@ -45,15 +45,14 @@ export default function ForwardMessage(props: Props) { | |||
| const chat = await BackendRemote.rpc.getFullChatById(accountId, chatId) | |||
| onClose() | |||
| if (!chat.isSelfTalk) { | |||
| selectChat(accountId, chat.id) | |||
There was a problem hiding this comment.
this is there because then you see the chat you are going to forward to, to prevent user mistakes.
In other words this behaviour of opening the chat before confirm and going back if you cancel is intentional.
There was a problem hiding this comment.
Ok - that should be worth a line of an explaining comment in the code :-)
So I have to find why the already opened chat is not scrolling down I guess
There was a problem hiding this comment.
maybe calling select chat again could already work. or whatever happens when you click again on the chat in the chat-list if you have already selected the chat,
Simon-Laux
approved these changes
Jul 21, 2024
Simon-Laux
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3834