show device message only once as unread

CHANGELOG.md

@@ -25,6 +25,7 @@
   - Case-insensitive search for non-ASCII messages
 - make ImageCropper use CSS-transforms for UI and canvas API to cut the result #3893
 - update stock translations #4051
+- show device message only once as unread #4057
 
 ### Fixed
 - Fix crash on "Settings" click when not on main screen (e.g. no account selected): hide the "settings" button

src/renderer/ScreenController.tsx

@@ -8,7 +8,7 @@ import { getLogger } from '../shared/logger'
 import AccountSetupScreen from './components/screens/AccountSetupScreen'
 import WelcomeScreen from './components/screens/WelcomeScreen'
 import { BackendRemote, EffectfulBackendActions } from './backend-com'
-import { updateDeviceChats } from './deviceMessages'
+import { updateDeviceChat, updateDeviceChats } from './deviceMessages'
 import { runtime } from './runtime'
 import { updateTimestamps } from './components/conversations/Timestamp'
 import { ScreenContext } from './contexts/ScreenContext'
@@ -95,6 +95,7 @@ export default class ScreenController extends Component {
         await this.addAndSelectAccount()
       }
     }
+    updateDeviceChats()
   }
 
   private async _getLastUsedAccount(): Promise<number | undefined> {
@@ -130,7 +131,6 @@ export default class ScreenController extends Component {
     )
     if (account.kind === 'Configured') {
       this.changeScreen(Screens.Main)
-      updateDeviceChats(this.selectedAccountId)
     } else {
       this.changeScreen(Screens.Welcome)
     }
@@ -167,7 +167,7 @@ export default class ScreenController extends Component {
       this.lastAccountBeforeAddingNewAccount = this.selectedAccountId
     }
     const accountId = await BackendRemote.rpc.addAccount()
-    updateDeviceChats(accountId, true) // skip changelog
+    updateDeviceChat(accountId, true) // skip changelog
     await this.selectAccount(accountId)
     return accountId
   }

src/renderer/deviceMessages.ts

@@ -1,6 +1,7 @@
 import { BackendRemote } from './backend-com'
+import { getDeviceChatId, markChatAsSeen } from './backend/chat'
 
-export async function updateDeviceChats(
+export async function updateDeviceChat(
   accountId: number,
   skipCurrentChangelog: boolean = false
 ) {
@@ -39,3 +40,14 @@ export async function updateDeviceChats(
 [Full Changelog](https://github.com/deltachat/deltachat-desktop/blob/main/CHANGELOG.md#1_46_0)`,
   })
 }
+
+export async function updateDeviceChats() {
+  const selectedAccount = await BackendRemote.rpc.getSelectedAccountId()
+  for (const accountId of await BackendRemote.rpc.getAllAccountIds()) {
+    await updateDeviceChat(accountId, false)
+    if (accountId !== selectedAccount) {
+      const devChatId = await getDeviceChatId(accountId)
+      if (devChatId) markChatAsSeen(accountId, devChatId)
+    }
+  }
+}