fix: "Contact info" contents jumping continuously #4068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
given the right contact name length, e.g. "aaaaaaa@example.com" Not the best solution, but appears to work for now. Closes #3971 Co-authored-by: Simon Laux <Simon-Laux@users.noreply.github.com>
WofWca
force-pushed
the
3971-fix-jumpy-contactinfo
branch
from
8c21198
to
b31503b
Compare
Simon-Laux
approved these changes
Aug 5, 2024
nicodh
approved these changes
Aug 5, 2024
Simon-Laux
added a commit
that referenced
this pull request
Aug 29, 2024
Simon-Laux
added a commit
that referenced
this pull request
Aug 29, 2024
* set min height for shared chats in profile view fixes #4092 * more clear varname * refactor styles a tiny bit to make status text scroll if there is little space * remove workaround from #4068, can't reproduce the bug of it anymore * fix that you can not click header button in dialog when they are on top of the navbar also see #4018 * add changelog entries
Simon-Laux
added a commit
that referenced
this pull request
Aug 29, 2024
* set min height for shared chats in profile view fixes #4092 * more clear varname * refactor styles a tiny bit to make status text scroll if there is little space * remove workaround from #4068, can't reproduce the bug of it anymore * fix that you can not click header button in dialog when they are on top of the navbar also see #4018 * add changelog entries
Simon-Laux
added a commit
that referenced
this pull request
Sep 8, 2024
* set min height for shared chats in profile view fixes #4092 * more clear varname * refactor styles a tiny bit to make status text scroll if there is little space * remove workaround from #4068, can't reproduce the bug of it anymore * fix that you can not click header button in dialog when they are on top of the navbar also see #4018 * add changelog entries
Simon-Laux
added a commit
that referenced
this pull request
Sep 9, 2024
* set min height for shared chats in profile view fixes #4092 * more clear varname * refactor styles a tiny bit to make status text scroll if there is little space * remove workaround from #4068, can't reproduce the bug of it anymore * fix that you can not click header button in dialog when they are on top of the navbar also see #4018 * add changelog entries
Simon-Laux
added a commit
that referenced
this pull request
Sep 9, 2024
* - convert project to use pnpm instead of npm - docs: mark e2e testing section as "defect" - remove vscode lint task * remove unused file * remove testcafe stuff * move bulk of source files, does not work yet * more progress like adjusting paths, making new packages and updating docs * ts: change all targets to es2018 * set min pnpm and nodejs versions in package.json * add check:types script * use pnpm workspace catalogs for shared dependencies * add scripts to change the core thats used * fix fmt * script to update/sync versions for targets * replace remaining references to electron from runtime interface: - `Electron.OpenDialogOptions` -> `RuntimeOpenDialogOptions` - qelectron.app.getPath()` -> `RuntimeAppPath` * fix lint of shared import in frontend * disable drag and drop files for now It is easier to fix later when we can test it * on paste: remove usage of `File.path` which was not set in some of the cases. * add missing debounce dependency to target-electron * fix lint of shared import in target-electron * global definition for electron-runtime * fix fmt * remove last direct usage of electron from frontend. move Deltachat jsonrpc transport to runtime-interface implementation * bundle backend code (targe-electron), move most dependencies to dev dependencies because they are now bundled * proper native sourcemap support during development for main process * mention `NODE_OPTIONS=--enable-source-maps` in docs * document `TEST_DIR` * fix loading locales in electron main process for devleopment Also add `DELTACHAT_LOCALE_DIR`env var to allow replacement of the localse folder. useful for debuging but you could also make a tool for users to live edit translations in a released version of deltachat together with the `--translation-watch` flag. * fix fmt * add the idea for end user translation tool to docs in a footnote * make build info part of the runtime and its generation part of the target-electron build script * rm used yerpc import in backend-com * move non shared types from shared to where they belong. Also improved some comments. * sort scripts by whether they work yet * progress on making frontend build (ts and scss so far) * fix path in comment * - sort static files into to their projects - new location for themes html-dist - make build themes script a bit faster and simpler * make copy fail with exit code 1 if dir is not found (unless it is started in watch mode) * make it run again (styles are broken but basics and logic work) * reintroduce dev script as alias to dev:electron to make transition easier for devs * fix blueprint import (bundle it) * fix images and icons * fix loading themes * update theming docs * remove dead code * use correct log level when logging to console in main process * make drag and drop work again this could have fixed the following issue #3595 as a side effect, if not then that issue is not fixable, altleast unless we start interacting with the OS Apis directly in a native module or by contributing to electron. * harden electron functions, only runtime can use them now * harden runtime by deleting the reference on window (`window.r`) after the first use. For development it is now accessible at `exp.runtime` but only in --devmode like `exp.rpc` * update_core docs: update the start command for electron * fix eslint issues and fix formatting * improve ./bin/test_for_missing_translations.sh script it's now more correct, helpful and faster * update ./bin/topEvil.sh script * scripts to update and check package versions * update prettierignore * update ./bin/update_background_thumbnails.sh script * fmt language list * update theme builder script to use compileString instead of renderSync, because the latter is deprecated * fix that composer was monospace font * tests for packages/shared * make migration test work * add testing to ci * add test-and-check script * make watch scripts work * docs: add hint about completion in terminal for pnpm * make packaging work again * update ci and docs * make `check:log-conventions` part of checks * update dev docs * update more pnpm commands * delete old package.json * update file tree in docs * ci: fix building preview * update the versions (for/from main branch rebase) * add changelog * runtime: also use catalog: dependency on @deltachat/jsonrpc-client to fix tests * test building in ci and fix ci test * ci: fix dev-builds * add comment to `previewBuild` variable in gen-electron-builder-config.js * update target versions * fix preview build ci * fix devbuild * fix tray and app icon * other appid for preview build on mac * fix readme commands * Fix if Contact has long bio, then shared chats are hidden (#4093) * set min height for shared chats in profile view fixes #4092 * more clear varname * refactor styles a tiny bit to make status text scroll if there is little space * remove workaround from #4068, can't reproduce the bug of it anymore * fix that you can not click header button in dialog when they are on top of the navbar also see #4018 * add changelog entries * fix fmt * update versions after rebase to match main branch: - deltachat-core (stdio-server and jsonrpc-client) 1.142.10 - electron-notarize 2.4 * fix chatlist image thumbnails (#4101) * fix chatlist image thumbnails * changelog entry * update core after rebase * fix changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
given the right contact name length, e.g. "aaaaaaa@example.com"
Not the best solution, but appears to work for now.
Closes #3971