Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve invite link chatlist item #4151

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Sep 28, 2024

Recommended review commit-by-commit

image

image

Follow-up to #4041

@WofWca WofWca force-pushed the wofwca/improve-invite-link-chatlist-item branch from f54b950 to 8ba0629 Compare September 28, 2024 14:59
@WofWca WofWca marked this pull request as ready for review September 28, 2024 14:59
@WofWca WofWca force-pushed the wofwca/improve-invite-link-chatlist-item branch from 8ba0629 to c2ac505 Compare September 28, 2024 15:01
Copy link
Contributor

@nicodh nicodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good by reading and testing.

Would be nice to have that in new chat search field too!

The invite link can also be a group invite.
...in the search field.

An invite link can also be a group invite,
so it would be confusing to show "New Contact" in that case.
when pasting an invite link in the search field.

Follow-up to 6980cf3
@WofWca WofWca force-pushed the wofwca/improve-invite-link-chatlist-item branch from c2ac505 to 42ba3c1 Compare September 30, 2024 11:51
@WofWca WofWca merged commit c087801 into main Sep 30, 2024
6 checks passed
@WofWca WofWca deleted the wofwca/improve-invite-link-chatlist-item branch September 30, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants