style: ugly reactions positioning on image msgs #4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/fix-image-reactions-overlayed
branch
from
d1c1122
to
0f6b654
Compare
Closes #4235 The issue probably existed ever since the reactions were added in the first place #2964, but it got worse after the removal of margin addition when adding a reaction (60e52c7). This commit should make things simpler because all positioning-related stuff is only done in `message/styles.module.scss`.
WofWca
force-pushed
the
wofwca/fix-image-reactions-overlayed
branch
from
0f6b654
to
5863ffe
Compare
nicodh
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4235
The issue probably existed ever since the reactions were added
in the first place #2964,
but it got worse after the removal of margin addition
when adding a reaction (60e52c7).
This should make things simpler as all positioning-related stuff
is only done in
message/styles.module.scss.Before:
After: