Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit options for "Delete Messages from Server" for chatmail accounts #4276

Merged
merged 4 commits into from
Oct 27, 2024
Merged

Limit options for "Delete Messages from Server" for chatmail accounts #4276

merged 4 commits into from
Oct 27, 2024

Conversation

Simon-Laux
Copy link
Member

@Simon-Laux Simon-Laux commented Oct 26, 2024 •
edited
Loading

and rename option "never" to "automatic" for chatmail.

closes #4113

@Simon-Laux Simon-Laux force-pushed the simon/i4113-limit-server-deletion-for-chatmail branch from 85ec5c9 to 37c349d Compare October 26, 2024 22:13
WofWca
WofWca approved these changes Oct 27, 2024
View reviewed changes
Copy link
Collaborator

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the code, appears to close #4113, though I did not test.

packages/frontend/src/components/Settings/Autodelete.tsx Outdated Show resolved Hide resolved
packages/frontend/src/components/Settings/Autodelete.tsx Outdated Show resolved Hide resolved
packages/frontend/src/components/Settings/Autodelete.tsx Show resolved Hide resolved
Simon-Laux and others added 3 commits October 27, 2024 18:04
@Simon-Laux @WofWca
Apply suggestions from code review
b0065ad 
Co-authored-by: WofWca <wofwca@protonmail.com>
@Simon-Laux @WofWca
Update packages/frontend/src/components/Settings/Autodelete.tsx
2f37116 
Co-authored-by: WofWca <wofwca@protonmail.com>
@Simon-Laux
fix fmt
33a9528
@Simon-Laux Simon-Laux merged commit d4e658e into main Oct 27, 2024
3 of 7 checks passed
@Simon-Laux Simon-Laux deleted the simon/i4113-limit-server-deletion-for-chatmail branch October 27, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WofWca WofWca WofWca approved these changes

@iequidoo iequidoo Awaiting requested review from iequidoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limit options for "Delete Messages from Server" for chatmail accounts
2 participants
@Simon-Laux @WofWca