Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ admin je suis informé des infos remontées par le champ SIRET #11013

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

colinux
Copy link
Member

@colinux colinux commented Nov 4, 2024

Closes #11008

A merger après #11099 ce sont les 3 derniers commits qui concernent cette PR.
(Il y a des doublons sur les adresses à cause du fait qu'on garde pour le moment les colonnes des types de données d'adresse)

Capture d’écran 2024-11-04 à 18 41 14
Capture d’écran 2024-12-04 à 16 23 37

@colinux colinux added the en attente En attente d'autres stories label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 89.36170% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.18%. Comparing base (2164d72) to head (8bc3017).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...asks/maintenance/populate_siret_value_json_task.rb 0.00% 3 Missing ⚠️
...ntrollers/administrateurs/procedures_controller.rb 87.50% 1 Missing ⚠️
app/jobs/api_entreprise/entreprise_job.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #11013       +/-   ##
===========================================
- Coverage   84.36%   72.18%   -12.19%     
===========================================
  Files        1181     1181               
  Lines       25997    26940      +943     
  Branches     4903     4608      -295     
===========================================
- Hits        21933    19447     -2486     
- Misses       4064     7493     +3429     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinux colinux force-pushed the admin-knows-api-fields branch 2 times, most recently from 3d46004 to eecb4eb Compare November 5, 2024 08:55
Copy link
Contributor

@mfo mfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sur le principe ca me semble top niveau ui/ux.
par contre sur l'implem je te propose qqch asap, j'espère que tu trouveras ça formidable :D

@colinux colinux removed the en attente En attente d'autres stories label Nov 20, 2024
@colinux colinux force-pushed the admin-knows-api-fields branch 4 times, most recently from ef85336 to f6fd8bc Compare November 27, 2024 14:40
@colinux colinux force-pushed the admin-knows-api-fields branch 3 times, most recently from ccba83f to ed423f3 Compare November 28, 2024 14:28
@colinux colinux changed the title (wip): ETQ admin je suis informé des infos remontées par le champ SIRET ETQ admin je suis informé des infos remontées par le champ SIRET Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ETQ admin je suis informé des infos remontées par les API à partir d'un SIRET, etc…
2 participants