Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV1720: Include local functions #108

Closed
bkoelman opened this issue Oct 17, 2017 · 2 comments
Closed

AV1720: Include local functions #108

bkoelman opened this issue Oct 17, 2017 · 2 comments

Comments

@bkoelman
Copy link
Contributor

Existing rule:

Name methods using a verb or a verb-object pair (AV1720)
Name methods using a verb like Show or a verb-object pair such as ShowDialog. A good name should give a hint on the what of a member, and if possible, the why.
Also, don't include And in the name of a method. It implies that the method is doing more than one thing, which violates the single responsibility principle explained in AV1115.

New language features to consider:

  • local functions
    I think this rule applies to local functions as well.

Proposal:

  • Replace "methods" with "methods and/or local functions" (in title and text)
  • Convert the text-reference to AV1115 into a hyperlink
@dennisdoomen
Copy link
Owner

👍

@bkoelman
Copy link
Contributor Author

I thought that we already had cross-reference links between rules. But it appears we do not. Filed #116 to make that possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants