Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated AV1570 #114

Merged
merged 2 commits into from
Oct 24, 2017
Merged

Updated AV1570 #114

merged 2 commits into from
Oct 24, 2017

Conversation

bkoelman
Copy link
Contributor

because it advocates outdated language usage.

Fixes #106.

because it advocates outdated language usage.
@dennisdoomen
Copy link
Owner

Should we not replace this old rule with something new?

@bkoelman
Copy link
Contributor Author

I think we should remove this rule, because it advocates outdated language usage.

Agreed.

So I created a PR to remove. But sure, we can keep some form of this. What do you have in mind?

@dennisdoomen
Copy link
Owner

Maybe we should keep the rule in a more shortened version and use the pattern matching syntax as an example how to improve the readability.

@bkoelman bkoelman changed the title Removed AV1570 Updated AV1570 Oct 22, 2017
@bkoelman
Copy link
Contributor Author

@dennisdoomen I have updated this PR. Can you please review again?

@dennisdoomen dennisdoomen merged commit f35f10c into dennisdoomen:master Oct 24, 2017
@bkoelman bkoelman deleted the del-AV1570 branch October 24, 2017 06:28
mapfel pushed a commit to stepahead/CSharpGuidelines that referenced this pull request Mar 22, 2021
* Removed AV1570

because it advocates outdated language usage.

* Review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants