Fix formatting of titles #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bkoelman which Ruby version are you using? I'm using |
|
Oh sorry, I only used build.bat, which produced the HTML files. I don't have Ruby installed. Can you provide some more info on what to download/install from where to build the site? I'm not sure where to go, based on what's in https://github.com/dennisdoomen/CSharpGuidelines/blob/master/README.md. |
|
Just checked once more on another machine and there it works according to the instructions. |
|
Hmm, this only fixes the titles in the PDF output. Not the HTML versions. |
added 2 commits
February 5, 2022 16:23
Moved the title out of its HTML tag so it gets proper formatting and added leading div to preserve anchors.
|
Pushed another commit to fix titles on website pages and in its search results.
|
|
Great work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the title out of its HTML tag so it gets proper formatting and added a leading div to preserve anchors.
Result when running locally:
Fixes #209.
/cc @julianbartel Though this seems to work, perhaps there's a better way. I know nearly nothing about the doc generation process here and I'm open to suggestions, so would be great if can chime in and take a look.