Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you lock the bson version? #305

Closed
jiawei397 opened this issue Dec 1, 2021 · 7 comments
Closed

Can you lock the bson version? #305

jiawei397 opened this issue Dec 1, 2021 · 7 comments

Comments

@jiawei397
Copy link

Thanks a lot. This is a very good project and we are using it.

But when I use lock.json, I meet that the CDN file hash will change always.

Can you lock the bson version like this?

https://cdn.skypack.dev/pin/bson@v4.5.4-F38JF4sWndM08oQ5WCDI/mode=imports/optimized/bson.js
@manyuanrong
Copy link
Member

#290
The fixed bson version was rolled back in this issue because the bson.d.ts file provided by skypack failed the type check in deno.
I don’t know if the problem has been resolved

@jiawei397
Copy link
Author

This is really sad news. If you don't care about the bson version, you can try the package I released. It is based on version 4.5.3.

https://deno.land/x/deno_bson@v0.0.2

Otherwise, I have to give up lock.json for a while.

@manyuanrong
Copy link
Member

@erfanium Have you tried importing on jspm before?

@erfanium
Copy link
Member

erfanium commented Dec 1, 2021

@jiawei397
Do you mean this? #306

@erfanium
Copy link
Member

erfanium commented Dec 1, 2021

@manyuanrong

Have you tried importing on jspm before?

jspm doesn't support .d.ts bundle file, so it doesn't matter to us whether use it or not.
skypack's js bundle was very tiny, so i picked skypack over jspm and esm.sh

@jiawei397
Copy link
Author

@jiawei397 Do you mean this? #306

I got the answer by this: denoland/deno#12955

I hoped it will work.

@erfanium
Copy link
Member

erfanium commented Dec 2, 2021

yeah, that's it
this change will fix your issue

@erfanium erfanium closed this as completed Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants