resloves #99 #132
Merged
resloves #99 #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hayd would you please review and merge this pull request |
|
Awesome! Could you add a test for this case? |
|
Hi @hayd , thanks for your response. I have updated the pull request. Yet I am not sure how to conduct the test locally. |
|
Hmm, GitHub actions didn't trigger, I wonder why that would be! Thanks for adding the test, will merge soon. |
|
Thanks |
|
believe I've turned on actions on the repo (it seems like it was turned off when moving org). tested locally and passing 👍 thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: error: Uncaught Error: Don't know how to parse column type: 1042