Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update decoders to parse float and return null on error #444

Merged
merged 13 commits into from
Feb 5, 2024
Merged

fix: update decoders to parse float and return null on error #444

merged 13 commits into from
Feb 5, 2024

Conversation

bombillazo
Copy link
Collaborator

@bombillazo bombillazo commented Feb 4, 2024 •
edited
Loading

Fixes #432

Breaking Changes

  • On value decode error, log error and return null (previously bubbled the error up)
  • Parse Float4 to number (previously returned as string)

Fixes

  • Format all project files using deno fmt
  • Update PG geometric type decoders with improved parse checks and error messaging

@bombillazo bombillazo changed the title Update Decoders Update decoders to parse float and return null on error Feb 4, 2024
bartlomieju
bartlomieju approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/data_types_test.ts Show resolved Hide resolved
tests/decode_test.ts Show resolved Hide resolved
@bombillazo bombillazo mentioned this pull request Feb 5, 2024
Open
@bombillazo bombillazo merged commit da5509e into main Feb 5, 2024
6 checks passed
@bombillazo bombillazo deleted the task/update-decoders branch February 5, 2024 02:39
@iuioiua iuioiua changed the title Update decoders to parse float and return null on error fix: update decoders to parse float and return null on error Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse/decode numeric columns as float/int
2 participants
@bombillazo @bartlomieju