Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using keyword with pool clients #473

Merged

Conversation

langpavel
Copy link
Contributor

@langpavel langpavel commented Feb 27, 2024

Related to #472

  • PoolClient
  • test for using client = await POOL.connect();

@langpavel
Copy link
Contributor Author

This PR can be merged independently

@langpavel langpavel force-pushed the pool-client-allow-using-syntax-472 branch from 2360150 to 2af3660 Compare February 27, 2024 22:52
@langpavel
Copy link
Contributor Author

Amended formating

@langpavel langpavel force-pushed the pool-client-allow-using-syntax-472 branch from 2af3660 to c407b21 Compare February 27, 2024 23:00
@langpavel
Copy link
Contributor Author

Amended linting, sorry :-)

@langpavel
Copy link
Contributor Author

langpavel commented Feb 28, 2024

I fixed another deno lint error. Now everything should be green I hope

@bombillazo
Copy link
Collaborator

You can run deno fmt --check , deno lint, deno test --doc client.ts mod.ts pool.ts client/ connection/ query/ utils/ from your project terminal if you want to anticipate what will fail.

@bombillazo bombillazo merged commit 5e9075a into denodrivers:main Feb 28, 2024
3 checks passed
@langpavel
Copy link
Contributor Author

Yeah, I discovered it late, thank you for merging!

@langpavel
Copy link
Contributor Author

Pipeline failed on main branch on deno fmt --check 🤦‍♂️

@bombillazo
Copy link
Collaborator

Please make a new PR to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants