Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno run --no-check=remote / deno check --remote does not report remote errors if a local check was already performed successfully #14632

Closed
lucacasonato opened this issue May 16, 2022 · 1 comment · Fixed by #15118
Assignees
Labels
bug Something isn't working correctly cli related to cli/ dir tsc related to the TypeScript tsc compiler

Comments

@lucacasonato
Copy link
Member

lucacasonato commented May 16, 2022

// https://example.com/test.ts
export const foo: string = 123;
// file:///main.ts
import { foo } from "https://example.com/test.ts";
# Check with default options
$ deno check /main.ts
Check file:///main.ts
$ echo $status
0

# Check with --remote
$ deno check --remote /main.ts
Check file:///main.ts
$ echo $status
0
# This should have errored!


# It does error when you wipe your $DENO_DIR
$ rm -rf $DENO_DIR
$ deno check --remote /main.ts
Check file:///main.ts
error: TS2322 [ERROR]: Type 'number' is not assignable to type 'string'.
export const foo: string = 123;
             ~~~
    at https://example.com/test.ts:1:14
$ echo $status
1
@lucacasonato lucacasonato added bug Something isn't working correctly tsc related to the TypeScript tsc compiler cli related to cli/ dir labels May 16, 2022
@dsherret
Copy link
Member

We could use the "check" value to bust the emit cache. For deno check, ideally we wouldn't emit though (but still use the cache to more determine if type checking is ok as it saves a lot of time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly cli related to cli/ dir tsc related to the TypeScript tsc compiler
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants