this._socket.removeListener is not a function

[ry]

This has come up with npm:nodemailer. See this comment #18303 (comment)

[littledivy]

I get the same error in Node.js as well, cc @dehrhard

/Users/divy/gh/node_modules/.deno/nodemailer@6.9.4/node_modules/nodemailer/lib/smtp-connection/index.js:896
        this._socket.removeListener('data', this._onSocketData); // incoming data is going to be gibberish from this point onwards
                     ^

TypeError: this._socket.removeListener is not a function
    at SMTPConnection._upgradeConnection (/Users/divy/gh/node_modules/.deno/nodemailer@6.9.4/node_modules/nodemailer/lib/smtp-connection/index.js:896:22)
    at Immediate.<anonymous> (/Users/divy/gh/node_modules/.deno/nodemailer@6.9.4/node_modules/nodemailer/lib/smtp-connection/index.js:246:26)
    at process.processImmediate (node:internal/timers:478:21)

Maybe a bug in nodemailer?

[dehrhard]

Hmm why do you think it's a bug in nodemailer? Isn't removeListener a method of socket and shouldn't that be provided by the deno compatibility layer?

[littledivy]

this._socket is not the net.Socket object when this code path is executed. You can try the exact same code in Node.js and it still errors.

[littledivy]

Oh, the reproduction code does not pass the connection option correctly, the error is gone with this change:

const connection = {
  from: "test@test.com",
  host: "host.host.com",
  port: 587,
  auth: {
    user: "123",
    pass: "456",
  },
};

const smtpClient = createTransport({
- connection,
+ ...connection,
  secure: true,
});

[dehrhard]

Oh dang, you're right. Looks like I have been misinterpreting the property. Looks like it is actually used for socket configuration which explains a lot

I'll try it out and see if it works.

[dehrhard]

Hey, I can confirm this works now. I knew it was something stupid 😄 Thanks, and again. Great work.