Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Rakkas (Vite/React framework) - Dev server #20852

Closed
birkskyum opened this issue Oct 9, 2023 · 2 comments
Closed

Support Rakkas (Vite/React framework) - Dev server #20852

birkskyum opened this issue Oct 9, 2023 · 2 comments
Labels
bug Something isn't working correctly node compat

Comments

@birkskyum
Copy link
Contributor

birkskyum commented Oct 9, 2023

Rakkas - Website - GitHub

Platform

Darwin 23.0.0 arm64 arm

Version

deno 1.37.1

Repro

  • deno run -A npm:create-rakkas-app@latest my-rakkas-app
  • proceed with default selection
  • cd my-rakkas-app
  • DENO_FUTURE=1 deno task dev

Expected

Launch of demo app

   RAKKAS  0.6.20 development server is running 💃 (ready in 442 ms)

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose

Actual

When I go to the http://localhost:5173/, this is what I see

➜ deno task dev
Task dev rakkas

   RAKKAS  0.6.20 development server is running 💃 (ready in 830 ms)

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
7:00:37 PM [vite] Error when evaluating SSR module /node_modules/.deno/rakkasjs@0.6.20/node_modules/rakkasjs/dist/server.js:
|- TypeError: Cannot read properties of undefined (reading 'env')
    at ../../node_modules/.pnpm/prop-types@15.8.1/node_modules/prop-types/index.js (/Users/admin/repos/deno-kitchensink/my-rakkas-app/node_modules/.deno/rakkasjs@0.6.20/node_modules/rakkasjs/dist/server.js, <anonymous>:994:17)
    at __require (/Users/admin/repos/deno-kitchensink/my-rakkas-app/node_modules/.deno/rakkasjs@0.6.20/node_modules/rakkasjs/dist/server.js, <anonymous>:41:50)
    at eval (/Users/admin/repos/deno-kitchensink/my-rakkas-app/node_modules/.deno/rakkasjs@0.6.20/node_modules/rakkasjs/dist/server.js, <anonymous>:1395:33)
    at async instantiateModule (file:///Users/admin/repos/deno-kitchensink/my-rakkas-app/node_modules/.deno/rakkasjs@0.6.20/node_modules/vite/dist/node/chunks/dep-52909643.js:56052:9)

Additional information

The production build works:

  • deno task build
  • deno task start (even todo example works)
@nathanwhit
Copy link
Member

It looks like this was fixed with #25291, it now runs without issue for me on 2.0.0-rc.2.

@birkskyum
Copy link
Contributor Author

birkskyum commented Sep 17, 2024

Oh, intersting that the dev server can start now!

When I go to the Todo page, and interacting with it, it'll prompt network errors in the console:

       POST http://localhost:5173/_data/development/src%2Froutes%2Ftodo%2Findex.page.tsx/1 400 (Bad Request)
Screenshot 2024-09-18 at 01 31 16

Parse error

@birkskyum birkskyum closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly node compat
Projects
None yet
Development

No branches or pull requests

3 participants