Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: timer firing in the next event loop triggers sanitizers #22764

Closed
satyarohith opened this issue Mar 7, 2024 · 1 comment
Closed

test: timer firing in the next event loop triggers sanitizers #22764

satyarohith opened this issue Mar 7, 2024 · 1 comment
Labels
bug Something isn't working correctly testing related to deno test and coverage

Comments

@satyarohith
Copy link
Member

From #22708 (comment)

Do you mind filing a bug against the sanitizers for this? We should not trigger the sanitizers if a timer fires in the next event loop.

To reproduce, remove last await in [node/http2.createServer()] unit test and run the test for several times until you get a timers leak error message.
@satyarohith satyarohith added bug Something isn't working correctly testing related to deno test and coverage labels Mar 7, 2024
@satyarohith satyarohith mentioned this issue Mar 7, 2024
Merged
@lucacasonato
Copy link
Member

This is now done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working correctly testing related to deno test and coverage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucacasonato @satyarohith