Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deno compile produces non deterministic build binary when there are npm dependencies #25084

Closed
i-api opened this issue Aug 18, 2024 · 5 comments · Fixed by #25092
Closed

deno compile produces non deterministic build binary when there are npm dependencies #25084

i-api opened this issue Aug 18, 2024 · 5 comments · Fixed by #25092
Labels
bug Something isn't working correctly compile related to the `deno compile` feature

Comments

@i-api
Copy link
Contributor

i-api commented Aug 18, 2024 •
edited
Loading

No description provided.

@i-api i-api changed the title deno compile produces non deterministic builds - I suspect the issue has to do with the lockfile deno.jsonc deno compile produces non deterministic build binary - I suspect the issue has to do with the lockfile deno.jsonc Aug 18, 2024
@i-api i-api changed the title deno compile produces non deterministic build binary - I suspect the issue has to do with the lockfile deno.jsonc deno compile produces non deterministic build binary - I suspect the issue has to do with the "npm:" specificer imports in lockfile deno.lock Aug 18, 2024
@i-api
Copy link
Contributor Author

i-api commented Aug 18, 2024

did futher testing, and npm: specifiers are indeed the cause.

@i-api
Copy link
Contributor Author

i-api commented Aug 18, 2024

#9244

@i-api
Copy link
Contributor Author

i-api commented Aug 18, 2024 •
edited
Loading

yes

@dsherret dsherret changed the title deno compile produces non deterministic build binary - I suspect the issue has to do with the "npm:" specificer imports in lockfile deno.lock deno compile produces non deterministic build binary when there are npm dependencies Aug 18, 2024
@dsherret dsherret added the bug Something isn't working correctly label Aug 18, 2024
@dsherret
Copy link
Member

#9244 is unrelated. You should probably be able to diff the executable and see what's being shifted around between compiles.

@dsherret dsherret mentioned this issue Aug 18, 2024
Merged
@dsherret dsherret added the compile related to the `deno compile` feature label Aug 19, 2024
@i-api
Copy link
Contributor Author

i-api commented Aug 20, 2024 •
edited
Loading

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working correctly compile related to the `deno compile` feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(compile): make output more deterministic dsherret/deno
2 participants
@dsherret @i-api