Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: always have the description come first in JSDocs for unstable symbols #25103

Open
iuioiua opened this issue Aug 19, 2024 · 5 comments
Labels
docs suggestion suggestions for new features (yet to be agreed)

Comments

@iuioiua
Copy link
Contributor

iuioiua commented Aug 19, 2024

A symbol being unstable is secondary compared to a description of what that symbol does. I suggest we move the description to be first, and any unstable notices second.

CC @thisisjofrank @crowlKats

image

@dsherret
Copy link
Member

I'm not sure about this. It being moved to the end increases the chance of it being cut off in auto-complete. Also, when someone is going to use something, they should see right away that it's unstable.

@crowlKats
Copy link
Member

this is a bug with docs.deno.com postprocessing of typings, for which i have a local fix, which will land later this week

@iuioiua
Copy link
Contributor Author

iuioiua commented Aug 20, 2024

To be clear, I suggest moving the unstable notice to the 2nd paragraph, not the last paragraph of the symbol's documentation. I think it's more important to the user to know what the symbol does, over its instability status.

this is a bug with docs.deno.com postprocessing of typings, for which i have a local fix, which will land later this week

Sorry, what exactly is a bug? Perhaps, we can have @experimental tags be somehow represented even in symbol lists like the screenshot I share.

@dsherret
Copy link
Member

dsherret commented Aug 20, 2024

To be clear, I suggest moving the unstable notice to the 2nd paragraph, not the last paragraph of the symbol's documentation. I think it's more important to the user to know what the symbol does, over its instability status.

I don't agree with that. I think being unstable is the most important thing for someone to know. People rarely even read docs and I think it should be the first thing people see in capital letters in order to catch their eye. This is especially important given we no longer require --unstable for type checking unstable APIs.

@iuioiua
Copy link
Contributor Author

iuioiua commented Aug 21, 2024

Let's agree to disagree then 😛

Either way, perhaps the suggestion in my previous comment might satisfy both preferences. Maybe it could be an "unstable" button or similar next to the symbol name.

@lucacasonato lucacasonato added the suggestion suggestions for new features (yet to be agreed) label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs suggestion suggestions for new features (yet to be agreed)
Projects
None yet
Development

No branches or pull requests

4 participants