Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow JSR dependency importing itself in deno publish --dry-run #25196

Open
dsherret opened this issue Aug 24, 2024 · 2 comments
Open

Disallow JSR dependency importing itself in deno publish --dry-run #25196

dsherret opened this issue Aug 24, 2024 · 2 comments
Labels
bug Something isn't working correctly publish Related to "deno publish" subcommand

Comments

@dsherret
Copy link
Member

dsherret commented Aug 24, 2024

It will not work when published to JSR. Also, it would cause things to resolve more slowly, the package to list itself as a dependency for the npm compat layer, and potentially cause a duplicate package to be resolved instead since the specifiers would be going through package resolution.

Ref #25191

@dsherret dsherret added bug Something isn't working correctly publish Related to "deno publish" subcommand labels Aug 24, 2024
@lucacasonato
Copy link
Member

I think it is useful to be able to import yourself in some cases - for example in doc comments. std does this. So this shouldn't be a blanket ban on self imports in deno_graph, but rather a ban of self imports in files referenced from entrypoints?

@dsherret
Copy link
Member Author

I think it's fine for doc comments.

but rather a ban of self imports in files referenced from entrypoints?

Yeah that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly publish Related to "deno publish" subcommand
Projects
None yet
Development

No branches or pull requests

2 participants