Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ext/node): do not prefix private function with _ in node compat JS implementation #26823

Open
kt3k opened this issue Nov 12, 2024 · 0 comments
Open

refactor(ext/node): do not prefix private function with _ in node compat JS implementation #26823

kt3k opened this issue Nov 12, 2024 · 0 comments
Labels
refactor

Comments

@kt3k
Copy link
Member

kt3k commented Nov 12, 2024

In Node compat JS implementation, we generally follow Node.js source code as far as possible, but with _ prefix for private functions in a file (ex. afterConnect in lib/net.js in Node.js becomes _afterConnect in our code base). This _ prefix is confusing for comparing the 2 code bases. So we should remove them.

related: #26661 (comment)
@kt3k kt3k mentioned this issue Nov 12, 2024
Merged
3 tasks
@kt3k kt3k changed the title Do not prefix private function with _ in node compat JS implementation refactor(ext/node): do not prefix private function with _ in node compat JS implementation Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kt3k @bartlomieju