Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust crates cannot be published to crates.io #3367

Closed
ry opened this issue Nov 18, 2019 · 3 comments · Fixed by #3556
Closed

Rust crates cannot be published to crates.io #3367

ry opened this issue Nov 18, 2019 · 3 comments · Fixed by #3556
Assignees
Labels
build build system or continuous integration related

Comments

@ry
Copy link
Member

ry commented Nov 18, 2019

As of v0.24.0 the deno-x86_64-pc-windows-msvc package for v0.24.0 is larger than the 10mb limit imposed by crates.io. This means we are unable to publish deno, deno_typescript, and deno_cli.

We will take this opportunity to reorganize our crates. The current setup was built back before we had proper cargo integration, and its complexities largely arise from shoehorning the GN build into "cargo package".

@ry ry added the build build system or continuous integration related label Nov 18, 2019
@ry ry self-assigned this Nov 18, 2019
@ry ry mentioned this issue Nov 19, 2019
43 tasks
@kevinkassimo
Copy link
Contributor

kevinkassimo commented Dec 8, 2019

Worth noting this makes building and publishing native plugins harder (have to clone this repository and use relative path to deno crate in Cargo.toml)

I'm planning to try building something that automatically download/build/install plugins using cargo, and this is a main blocking issue.

@ry
Copy link
Member Author

ry commented Dec 8, 2019

The problem is only with the windows crate... as a short term solution we could remove support for windows crate and publish 0.26

@kevinkassimo
Copy link
Contributor

Hmm I wonder if everything in the deno crate is needed to create a plugin. It might make sense to split out another crate that provides the minimal interface just for plugin message passing (but yeah this also means plugins using this minimal crate would not be able to create workers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build system or continuous integration related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants