Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test flaky due to fs event - #4204

Closed
ecyrbe opened this issue Mar 1, 2020 · 2 comments · Fixed by #4266
Closed

unit test flaky due to fs event - #4204

ecyrbe opened this issue Mar 1, 2020 · 2 comments · Fixed by #4266
Labels
bug Something isn't working correctly

Comments

@ecyrbe
Copy link
Contributor

ecyrbe commented Mar 1, 2020

I get these on my PR, that do not seem to be related to code i pushed #4202 :

OK     fsEventsBasic (2.00ms)
##[error]thread '<unnamed>' panicked at 'fs events error: SendError(Ok(FsEvent { kind: "modify", paths: ["/tmp/8259b2ca/file2.txt"] }))', src/libcore/result.rs:1188:5
@ecyrbe
Copy link
Contributor Author

ecyrbe commented Mar 1, 2020

@bartlomieju any idea why this fs event test panics ?

@bartlomieju
Copy link
Member

Most likely because FsWatcher doesn't stop watching after it's closed an tries to push new notification on a channel that has been closed.

CC @ry you might want to call 'unwatch' when closing watcher resource

@bartlomieju bartlomieju added the bug Something isn't working correctly label Mar 1, 2020
@ry ry changed the title unit test failing due to fs event unit test flaky due to fs event - Mar 5, 2020
@ry ry closed this as completed in #4266 Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants