Require read permission to perform Deno.bundle()

[cknight]

Deno.bundle() takes in as argument a file name as a string. If the file is of a supported media type (currently javascript, JSX, Typescript, TSX, Json or Wasm), it will bundle that file up and return the output to the calling module as a string of Javascript. No permissions are required. This effectively gives the calling module the ability to read the contents of any these media types located anywhere on the file system without requiring any permission.

Proof of concept

/some/other/dir/secrets.json

{"my_secret_API_key":"abcd1234"}

/deno/module/dir/bundle_poc.ts

const [ maybeDiagnostics, output ] = await Deno.bundle("/some/other/dir/secrets.json");
console.log(output);

when executed as:
deno bundle_poc.ts

The output (trimmed) is:

Compile file:///deno/module/dir/bundle_poc.ts
// Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.

// This is a specialised implementation of a System module loader.

// @ts-nocheck
/* eslint-disable */

let System, __inst, __inst_s;

<...trimmed output...>

{ "my_secret_API_key": "abcd1234" }

__inst_s("secrets");

As demonstrated above, this method exposes the json data to the calling module. If Deno.bundle() can access any of these media types on the file system and allow the content to be accessed in the module, it should be required to run under the --allow-read permission.

[kitsonk]

This isn't specific to Deno.bundle()... We currently allow importing of JSON without permissions full stop. Deno.bundle() uses the same infrastructure.

import secrets from "/some/other/dir/secrets.json";

console.log(secrets);

Ref #2768 where we discussed --allow-read for JSON modules briefly.
Ref #3401 talking about importing outside of the root.

PR #4404 fixes a defect where the JSON is simply inlined in the bundle, but it still gives access to anything you are allowed to import.

[bartlomieju]

I think this issue is no longer valid - any runtime API (import(), Deno.compile(), Deno.bundle(), Deno.transpileOnly()) does permission check before loading files. Additionally neither WASM nor JSON imports are supported anymore (past v1.0.0)

[cknight]

Thanks @bartlomieju, I agree. Closing.