Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 on importing type declarations files from pika.dev using Deno 1.0.1 #5696

Closed
mdubourg001 opened this issue May 21, 2020 · 3 comments · Fixed by #5726
Closed

404 on importing type declarations files from pika.dev using Deno 1.0.1 #5696

mdubourg001 opened this issue May 21, 2020 · 3 comments · Fixed by #5726
Assignees
Labels
bug Something isn't working correctly cli related to cli/ dir

Comments

@mdubourg001
Copy link

mdubourg001 commented May 21, 2020

Hi there,

I've been working on some tooling that requires the use of a module I import from cdn.pika.dev. as follows:

import { parse } from "https://cdn.pika.dev/html5parser@^1.1.0";

These imports used to work when I was using Deno 1.0.0-rc3, but ever since I upgraded to the last Deno release (1.0.1), these imports break to a 404 error:

error: Import 'https://cdn.pika.dev/-/html5parser@v1.1.2-0fAkC9viFOtRB3VnrC0m/dist=es2019,mode=types/types.d.ts' failed: 404 Not Found

As mentioned in this issue I commented on on the pika/cdn repo, I first thought the issues came from Pika, but I just tried to downgrade to Deno 1.0.0-rc3, and the imports work great again.

@bartlomieju
Copy link
Member

Must be related to #5029; needs more investigation

@bartlomieju
Copy link
Member

@mdubourg001 I'm not sure if that's a Deno bug, I've written down my findings: skypackjs/skypack-cdn#8 (comment)

@bartlomieju
Copy link
Member

Okay I found the issue after all; #5029 introduced bad redirection handling which causes this problem. I'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly cli related to cli/ dir
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants