From c59a38fa6df1fe86d0dc096cb85d8abdf4d762aa Mon Sep 17 00:00:00 2001 From: Matt Mastracci Date: Tue, 5 Mar 2024 18:51:22 -0700 Subject: [PATCH] fix(cli): improve logging on failed named pipe --- ext/io/winpipe.rs | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/ext/io/winpipe.rs b/ext/io/winpipe.rs index 1495cbed15789f..f6e66eeb3015d2 100644 --- a/ext/io/winpipe.rs +++ b/ext/io/winpipe.rs @@ -81,7 +81,10 @@ fn create_named_pipe_inner() -> io::Result<(RawHandle, RawHandle)> { // This should not happen, so we would like to get some better diagnostics here. // SAFETY: Printing last error for diagnostics unsafe { - eprintln!("*** Unexpected server pipe failure: {:x}", GetLastError()); + eprintln!( + "*** Unexpected server pipe failure '{pipe_name:?}': {:x}", + GetLastError() + ); } return Err(io::Error::last_os_error()); } @@ -110,13 +113,19 @@ fn create_named_pipe_inner() -> io::Result<(RawHandle, RawHandle)> { || error == winapi::shared::winerror::ERROR_PATH_NOT_FOUND { // Exponential backoff, but don't sleep longer than 10ms - eprintln!("*** Unexpected client pipe not found failure: {:x}", error); + eprintln!( + "*** Unexpected client pipe not found failure '{pipe_name:?}': {:x}", + error + ); std::thread::sleep(Duration::from_millis(10.min(2_u64.pow(i) + 1))); continue; } // This should not happen, so we would like to get some better diagnostics here. - eprintln!("*** Unexpected client pipe failure: {:x}", error); + eprintln!( + "*** Unexpected client pipe failure '{pipe_name:?}': {:x}", + error + ); let err = io::Error::last_os_error(); // SAFETY: Close the handles if we failed unsafe {