From 56926945f1adc4fc1de1caf5fd51d35c887dcaaa Mon Sep 17 00:00:00 2001
From: David Sherret <dsherret@gmail.com>
Date: Sun, 29 Dec 2024 13:08:21 -0500
Subject: [PATCH] perf(fs): reduce metadata lookups

---
 ext/fs/std_fs.rs | 34 +++++++++++++++++++---------------
 1 file changed, 19 insertions(+), 15 deletions(-)

diff --git a/ext/fs/std_fs.rs b/ext/fs/std_fs.rs
index 86ad2131601bab..76d37e430c1c21 100644
--- a/ext/fs/std_fs.rs
+++ b/ext/fs/std_fs.rs
@@ -723,30 +723,34 @@ fn cp(from: &Path, to: &Path) -> FsResult<()> {
     }
   }
 
-  match (fs::metadata(to), fs::symlink_metadata(to)) {
-    (Ok(m), _) if m.is_dir() => cp_(
-      source_meta,
-      from,
-      &to.join(from.file_name().ok_or_else(|| {
-        io::Error::new(
-          io::ErrorKind::InvalidInput,
-          "the source path is not a valid file",
-        )
-      })?),
-    )?,
-    (_, Ok(m)) if is_identical(&source_meta, &m) => {
+  if let Ok(m) = fs::metadata(to) {
+    if m.is_dir() {
+      return cp_(
+        source_meta,
+        from,
+        &to.join(from.file_name().ok_or_else(|| {
+          io::Error::new(
+            io::ErrorKind::InvalidInput,
+            "the source path is not a valid file",
+          )
+        })?),
+      );
+    }
+  }
+
+  if let Ok(m) = fs::symlink_metadata(to) {
+    if is_identical(&source_meta, &m) {
       return Err(
         io::Error::new(
           io::ErrorKind::InvalidInput,
           "the source and destination are the same file",
         )
         .into(),
-      )
+      );
     }
-    _ => cp_(source_meta, from, to)?,
   }
 
-  Ok(())
+  cp_(source_meta, from, to)
 }
 
 #[cfg(not(windows))]