Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate shebang fix from the Deno repo to here #85

Closed
dsherret opened this issue Jan 3, 2023 · 1 comment · Fixed by #88
Closed

Migrate shebang fix from the Deno repo to here #85

dsherret opened this issue Jan 3, 2023 · 1 comment · Fixed by #88

Comments

@dsherret
Copy link
Member

dsherret commented Jan 3, 2023

https://github.com/denoland/deno/pull/17113/files
@dsherret dsherret mentioned this issue Jan 24, 2023
Merged
@yacinehmito
Copy link
Contributor

yacinehmito commented May 3, 2023 •
edited
Loading

This is not really fixed, as the shebang is still not being emitted when calling the JS API. It took me a while to understand why the Rust unit test was passing but not the JS one.

The fix works Rust-side but not JS-side because the default loader is the one from deno_cache, and deno_cache strips the shebang when loading, as seen in the code.

What is the usefulness of stripping the shebang in deno_cache? Is it something that can be removed, or at least made configurable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: include shebang in output dsherret/deno_emit
2 participants
@dsherret @yacinehmito