chore: Implement strict mode #453
Conversation
|
This task is more complicated than I originally thought; passing
|
|
Maybe add problematic files in exclude for the check and fix it in further PR? Otherwise it will be a bit too much work in the same PR i think. |
@zekth as stated above, Deno's TS compiler does not respect either of options |
I was meaning having strict_test.ts using strict.tsconfig.json for example. But we dont have to let it stay here for long. |
fs module strict
strict fix
|
You could consider putting a minimal tsconfig in tests and extend it in the root to avoid the ignored options. But otherwise, good work. |
bartlomieju
changed the title
|
Let's wait for #444 before landing this PR |
|
LGTM but holding for #444 |
| @@ -37,4 +37,4 @@ jobs: | |||
| - bash: echo "##vso[task.prependpath]C:\Users\VssAdministrator\.deno\\bin" | |||
| - bash: npx eslint **/*.ts --max-warnings=0 | |||
| - bash: deno.exe run --allow-run --allow-write --allow-read format.ts --check | |||
| - bash: deno.exe run --allow-run --allow-net --allow-write --allow-read test.ts | |||
| - bash: deno.exe run --allow-run --allow-net --allow-write --allow-read --config=tsconfig.test.json test.ts | |||
There was a problem hiding this comment.
Why is the --config flag being added here?
There was a problem hiding this comment.
Well I tried using strict mode in linter but it was not making any difference. So I explicitly tell Deno's TS compiler to use strict mode.
| @@ -26,7 +26,7 @@ jobs: | |||
| - script: echo '##vso[task.prependpath]$(HOME)/.deno/bin/' | |||
| - script: eslint **/*.ts --max-warnings=0 | |||
| - script: deno run --allow-run --allow-write --allow-read format.ts --check | |||
| - script: deno run --allow-run --allow-net --allow-write --allow-read test.ts | |||
| - script: deno run --allow-run --allow-net --allow-write --allow-read --config=tsconfig.test.json test.ts | |||
There was a problem hiding this comment.
We need to de-dup these commands at some point...
Probably we should try to copy how Tokio uses Azure Pipelines
There was a problem hiding this comment.
Definitely, I'll do that in followup PR
This change changes the text to "Loading..." once the button is clicked instead of disappearing. It also prevents the button from actioning anything while in the loading state.
Closes #213