Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

todo: link to user GitHub profile page #347

Closed
iuioiua opened this issue Jul 5, 2023 · 2 comments · Fixed by #356
Closed

todo: link to user GitHub profile page #347

iuioiua opened this issue Jul 5, 2023 · 2 comments · Fixed by #356
Labels
good first issue Good for newcomers

Comments

@iuioiua
Copy link
Contributor

iuioiua commented Jul 5, 2023

On each account page, there should be a link to the user's GitHub profile page as part of the user details. The GitHub icon component in /components/icon.tsx can be used.
@iuioiua iuioiua added the good first issue Good for newcomers label Jul 5, 2023
@iuioiua iuioiua changed the title todo: link to GitHub profile page todo: link to user GitHub profile page Jul 5, 2023
@niklasmtj
Copy link
Contributor

What do you think about putting the icon in front of the number of submissions? So in your case <GitHub> | 16 submission or even underneath that? This way we could prepare a place for more links in the future like personal website etc.

@iuioiua
Copy link
Contributor Author

iuioiua commented Jul 6, 2023 •
edited
Loading

I'm open to ideas. Happy to take a look at suggestions.

@niklasmtj niklasmtj mentioned this issue Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add GitHub profile to user's page niklasmtj/saaskit
2 participants
@niklasmtj @iuioiua