Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: rework and fix std/http/file_server and tests #3770

Closed
iuioiua opened this issue Nov 6, 2023 · 0 comments · Fixed by #3779
Closed

proposal: rework and fix std/http/file_server and tests #3770

iuioiua opened this issue Nov 6, 2023 · 0 comments · Fixed by #3779
Assignees

Comments

@iuioiua
Copy link
Contributor

iuioiua commented Nov 6, 2023

std/http/file_server tests are currently flaky. One reason this may be happening is that each of these tests opens a new process and makes fetch() calls. However, such network calls and new processes are not needed. Instead, we can use something like const res = await serveDir(req). This would be a far more straightforward method of testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant